CVSTrac Legacy Code

Timeline
Login

Timeline

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

50 check-ins occurring around d0137d8b1992983e.

2009-03-13
02:22
(#783) direct inspections to the appropriate positions in chngview from both the timeline, RSS, as well as after sumitting them. (check-in: 3b02e5ca7d user: cpb tags: trunk)
02:00
(#783) when we append to a ticket we get bounced back to the ticket view. Might as well get bounced back to the anchor we just added. (check-in: fb194a19a2 user: cpb tags: trunk)
2009-03-10
03:06
(#791) first stab at a generic report RSS feed. Item titles need some fine tuning and there's no way to determine dates, but otherwise it seems sane. (check-in: afb2fee9b7 user: cpb tags: trunk)
01:19
the dashed-forms of the git commands are now not reliably avaiable. (check-in: ec1de0af03 user: cpb tags: trunk)
2009-03-08
00:14
(#791) allow individual pages to have their own RSS feeds

This means we need to allow generic RSS substitutions in the header. To that end, we add %R for the URL and %F for the title (a distinct feed needs a distinct title).

Figuring out whether a page has its own RSS feed is done by looking for an "RSS" entry in the action bar. The title is built from the project name and the current page title.

Then, to override the default (timeline) RSS feed on any given page, it's just a matter of doing something like:

common_add_action_item(mprintf("tkthistory.rss?tn=%d",tn), "RSS");

and the header output logic will just pick it up. (check-in: c72535f17c user: cpb tags: trunk)

2009-03-07
00:42
(#231) ditch the opaque class names like "border2" and "bkgnd1" and replace with more meaningful class names, and related cleanups. (check-in: 64a9390abe user: cpb tags: trunk)
2009-03-06
03:06
(#177) makes HTML entities _work_ in wiki markup and (maybe) other places

In order to allow it to work in both normal web browsing and the encoding needed for RSS (where we _need_ to encode even entities), I modified htmlize (%h) to take an "allow entities" flag, and added a new %R formatting option which disables this flag. %R is used by the RSS formatter to do the final content generation. This means anywhere wiki content is allowed someone can write é and, apparently, it works.

Keep in mind that I don't normally use anything except ASCII in my day-to-day environment, so someone who cares about this stuff should maybe test it out a bit more than myself. (check-in: 14e235cdd5 user: cpb tags: trunk)

2009-03-02
00:07
(#787) append/add remarks should be hidden for users without ticket write permissions (check-in: 10e5c9bba7 user: cpb tags: trunk)
2009-02-25
02:04
(#786) ensure local attachments links from the {quote:{image:}} tags aren't broken in the RSS feed. This requires adding an appropriate page id to the formatting calls. (check-in: 4149691655 user: cpb tags: trunk)
2009-02-19
03:38
(#783) when dealing with remarks in the timeline, break them out separately and (try to) link directly to a new remark in the ticket. This won't work perfectly when dealing with direct edits to the remark field, but for normal use it should be fine. (check-in: 743d4611de user: cpb tags: trunk)
03:23
(#783) generate the link to appended remarks by targetting what should be the anchor. Doing so from the timeline will be a little more complicated. (check-in: 52ecfd6559 user: cpb tags: trunk)
02:59
(#783) when appending a ticket comment, write an HTML anchor based on the change time so we can find it later. (check-in: 7c22978975 user: cpb tags: trunk)
02:33
(#781) don't run the external diff filter if the output is supposed to be _raw_ (check-in: 488fc0db1e user: cpb tags: trunk)
2009-01-17
16:31
(#777) an index on filechng(vers) speeds the update quite a bit for larger projects. (check-in: c6b04561ea user: cpb tags: trunk)
2008-12-28
15:03
(#774) make external tools work in reports (check-in: 976179c75a user: cpb tags: trunk)
2008-11-27
17:49
oops, that's supposed to be a call, not output (check-in: d78282a902 user: cpb tags: trunk)
2008-11-14
15:34
(#768) merge [1018] fix printf argument (Leaf check-in: 05b9a75c31 user: cpb tags: release2_0_1)
15:33
(#768) printf argument needs escaping, and it's the wrong one anyways (check-in: d04d9de48b user: cpb tags: trunk)
2008-10-29
18:46
(#766) merge [1016]: handle missing f parameter (check-in: 30138bdb73 user: cpb tags: release2_0_1)
18:45
(#766) handle missing f parameter (check-in: 4b004e65d5 user: cpb tags: trunk)
2008-10-23
16:24
we need to armour the cookie value. Otherwise, it can contain values which aren't legal in a CGI parameter name. (check-in: 89bfff7fd9 user: cpb tags: trunk)
2008-10-21
02:05
add some CSRF (http://en.wikipedia.org/wiki/Cross-site_request_forgery) prevention. It's a little over-engineered in places, but the patch itself is non-intrusive enough that this isn't a huge problem. (check-in: 8a6641cd16 user: cpb tags: trunk)
2008-10-11
01:03
(#764) admin/setup permissions should also imply wiki. (check-in: 48506efca4 user: cpb tags: release2_0_1)
01:02
(#764) _setup_ permissions should also imply wiki permissions. Simplify the Windows condition slightly. (check-in: e1b44eb962 user: cpb tags: trunk)
2008-10-09
22:59
(#764) merge [1010]: don't use CGI output stuff when we don't have a URL. This may not be needed in HEAD, but it certainly won't hurt. (check-in: d0137d8b19 user: cpb tags: trunk)
19:57
(#764) don't try to use CGI methods when there's no URL. (check-in: 1b03bde87f user: cpb tags: release2_0_1)
2008-09-16
15:12
Carriage returns, line feeds and tabs in the command line may make the Windows command line incomplete. (check-in: 79df195944 user: ono tags: trunk)
15:10
(#118) %c using owner when no contact specified was broken by 1.111 commit. (check-in: 5e407f9cfd user: ono tags: trunk)
14:23
(#762) fix order of month/date in output. (check-in: bf7c25aa02 user: cpb tags: trunk)
2008-09-15
14:40
Update MinGW makefiles so they work fine with latest code. (check-in: c0b4bd2396 user: ono tags: trunk)
14:36
(#761) correct project name to correct case for case-insensitive Windows (check-in: 3fa5c26da1 user: ono tags: trunk)
13:12
In order to actually _apply_ a patchset, you really want to have the relative name in the context section. Some versions of patch don't seem to want to pick it up from Index. This is fine for shallow projects (i.e. all files in one directory) but it doesn't work for deep projects. So change the rcsdiff command line so we get full relative pathnames in the patch. (check-in: 88cdf75093 user: cpb tags: trunk)
2008-06-30
21:31
(#759) when putting the id in the hidden field for deletion, use the right formatting (%h vs %t). (check-in: f6072b91dd user: cpb tags: trunk)
2008-06-08
15:11
(#758) patch from filodej to implement external filters for GIT diffs. Remove the File List interface for GIT since it's not applicable. (check-in: 1a7ca06e2b user: cpb tags: trunk)
2008-04-17
01:43
(#742) allow the report editor to enter a wiki description. An abbreviated version gets shown in the report list. It _doesn't_ get shown in embedded reports. This may or may not be desirable, depending on the context of the embedding. (check-in: ff060f9fec user: cpb tags: trunk)
01:20
(#749) a few formatting tweaks (check-in: 8b996f3a7f user: cpb tags: trunk)
2008-04-16
02:10
#749, #742: database schema changes, related UI changes *: add a "reason" field to the WIKI table to describe a change, add the corresponding text field to the wikiedit page and display the field in various places. Probably could be done in more places. *: add a "comment" field to the INSPECT table to hold wiki markup. Some more work needs to be done in here. *: add a "description" field to the REPORTFMT table to hold a wiki description of a report. No UI element yet, just a placeholder in the database. (check-in: 3a6b72e203 user: cpb tags: trunk)
2008-04-12
01:23
(#231) have a go at eliminating the use of

It was mostly in error output, so added a error class to the CSS and updated all the code. Mind you, error output really should be standardized in a single function somewhere.

Only one left in the table stuff in /cvstrac/view.c (check-in: f18b4a5e70 user: cpb tags: trunk)

00:44
(#751) add a "safe ticket editting mode" similar to Trac's which _should_ prevent users from blindly stomping on each others changes.

Basically, when a user starts editting a ticket (or appending a remark), the last "changetime" is embedded in the form. At submit time, CVSTrac checks to ensure that changetime is still good and refuses to proceed. The user still has all the change visible and can copy them elsewhere, but can't "finish" the change. A "force" checkbox might be useful here?

By default, this is disabled. (check-in: 6e09701d50 user: cpb tags: trunk)

2008-04-11
12:07
using the history entry date works better if we actually do use it. (check-in: 35f37e602d user: cpb tags: trunk)
2008-04-10
00:54
(#750) if we can't map a tag to a previous tag like the history suggests we should, just go with the date of the current history entry rather than dropping the tag entirely. (check-in: b7bf9a9b1b user: cpb tags: trunk)
00:50
(#744) use =strcasecmp()= and =strncasecmp()= (both POSIX standard calls) rather than the now non-public SQLite versions. (check-in: 989410317a user: cpb tags: trunk)
2008-02-18
11:25
Forgot why we did that. Comment it so I remember next time (check-in: 2fae12040f user: cpb tags: trunk)
2008-01-01
00:16
(#738) output the resulting row count at the end of the report (check-in: cdccd40b7a user: cpb tags: trunk)
2007-12-19
22:36
(#734) explicitly check for IIS before trying to work around a bunch of IIS bugs. Note that we expose the g.isIIS even on non-Windows O/S. This won't affect performance, but makes the code clearer in places. (check-in: 4148655620 user: cpb tags: trunk)
02:23
(#733) fix header ordering here, too (check-in: fa9ba6c33a user: cpb tags: trunk)
00:05
(#733) fix header ordering so browse.h is last (check-in: 18d8927ccc user: cpb tags: trunk)
00:04
(#734) SCRIPT_NAME _can_ be undefined in some servers (check-in: c173f68b1f user: cpb tags: trunk)
2007-12-16
22:45
(#732) always display ticket numbers with a 'hash' (check-in: b42dfa7be8 user: cpb tags: trunk)
2007-11-07
12:41
Removing empty #729 (check-in: b64cd9f684 user: ono tags: trunk)